Skip to content

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented May 24, 2021

Proposed changes (including videos or screenshots)

Duplicate of #21406

PS: Had to close the previous PR because some of the builds were not passing

Issue(s)

#21033

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 added this to the 3.15.0 milestone May 25, 2021

const corsOptions = {
origin: (origin, callback) => {
if (!origin || (corsEnabled && (allowListOrigins.includes('*') || allowListOrigins.includes(origin))) || origin === settings.get('Site_Url')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware there's an open PR #22106 that aims to modify Site_Url setting)

@murtaza98
Copy link
Contributor Author

The failing builds is throwing the following error, but I don't think its related to any of the changes we've here 😕
image

@sampaiodiego
Copy link
Member

The failing builds is throwing the following error, but I don't think its related to any of the changes we've here
image

omg.. I don't know why this is happening some times.. one way I came across to solve this is closing the PR and opening a new one based on the same branch.. :(

@murtaza98
Copy link
Contributor Author

The failing builds is throwing the following error, but I don't think its related to any of the changes we've here
image

omg.. I don't know why this is happening some times.. one way I came across to solve this is closing the PR and opening a new one based on the same branch.. :(

Okay let me try this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants